Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ispc: add x86_64-darwin to platforms. #70846

Merged
merged 2 commits into from Nov 4, 2019
Merged

ispc: add x86_64-darwin to platforms. #70846

merged 2 commits into from Nov 4, 2019

Conversation

athas
Copy link
Contributor

@athas athas commented Oct 9, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 9, 2019
@marsam
Copy link
Contributor

marsam commented Oct 10, 2019

@GrahamcOfBorg eval
@GrahamcOfBorg build ispc

@ofborg ofborg bot requested a review from aristidb October 10, 2019 02:46
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 14, 2019

@GrahamcOfBorg build ispc

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 14, 2019

On Darwin:

1 / 1360 tests FAILED compilation:
        ./tests/transcendentals-10-0.ispc
NEW COMPFAILS:
        ./tests/transcendentals-10-0.ispc

@athas athas mentioned this pull request Oct 14, 2019
Closed
10 tasks
@athas
Copy link
Contributor Author

athas commented Oct 14, 2019

Addressed in #71134 in the only robust way.

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 14, 2019

Recent history on Hydra does not show any failures for amd64-linux.
Can't we just set doCheck = !stdenv.isDarwin; as part of this PR instead ? (julia or nim are similar compilers examples)

@athas
Copy link
Contributor Author

athas commented Oct 14, 2019

Sure, but what happens next time this flaky test suite fails? It's already been reduced to pointlessness, since to work reliably on Hydra, it only uses SSE2 instructions, and nobody interested in using ISPC is going to stick to SSE2.

@marsam
ispc: only check on Linux
b60853c 
The test suite tries to execute `transcendentals` tests, which is not
expected to work anywhere except Linux.
@marsam marsam merged commit 22378e6 into NixOS:master Nov 4, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 4, 2019
@marsam @dtzWill
Merge pull request NixOS#70846 from athas/ispc-macos
e03090f 
ispc: add x86_64-darwin to platforms.

Closes NixOS#71134

(cherry picked from commit 22378e6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristidb aristidb Awaiting requested review from aristidb

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@athas @marsam @c0bw3b