Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromaprint: 1.3.2 -> 1.4.3 #70848

Closed
wants to merge 1 commit into from
Closed

Conversation

samdoshi
Copy link
Contributor

@samdoshi samdoshi commented Oct 9, 2019

Motivation for this change

Upgrade chromaprint 1.3.2 to 1.4.3. This fixes an issue with Picard and fpcalc, though Picard itself has an annoying habit of saving the absolute path to fpcalc (i.e. in the store) in the user configuration, and thus updates to fpcalc are not picked up automatically. I'm planning on submitting a patch to remove that behaviour from Picard.

nix-review wanted to build a lot... so I've left it running for a bit...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ehmry

@samdoshi
Copy link
Contributor Author

samdoshi commented Oct 9, 2019

Looks like this PR is a dupe of #60137

Which I found when I had the exact same issue with Clementine.

@samdoshi samdoshi closed this Oct 9, 2019
@samdoshi samdoshi deleted the chromaprint branch April 9, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant