Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seg3d: remove #70774

Merged
merged 1 commit into from Nov 21, 2019
Merged

seg3d: remove #70774

merged 1 commit into from Nov 21, 2019

Conversation

cko
Copy link
Member

@cko cko commented Oct 8, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@KamilaBorowska KamilaBorowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to properly error-out from basic testing.

@cko cko force-pushed the seg3d branch 2 times, most recently from db6bd52 to dbcc690 Compare November 9, 2019 23:31
@cko
Copy link
Member Author

cko commented Nov 9, 2019

@jtojnar I saw that you added #73126 to "Picking up garbage". This might be a candidate as well.

@jtojnar jtojnar added this to To do in Picking up garbage via automation Nov 9, 2019
@jtojnar jtojnar moved this from To do to In progress in Picking up garbage Nov 9, 2019
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I tried updating it but they're vendoring ~15 packages that get cloned by cmake at build time and a few other impurities.
If nobody cares about it, I'll not waste my time.

@c0bw3b c0bw3b merged commit e58e0d8 into NixOS:master Nov 21, 2019
Picking up garbage automation moved this from In progress to Done Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants