Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing descriptions #70771

Merged
merged 1 commit into from Oct 8, 2019
Merged

Add missing descriptions #70771

merged 1 commit into from Oct 8, 2019

Conversation

cko
Copy link
Member

@cko cko commented Oct 8, 2019

Motivation for this change

A lot of packages have incomplete meta information. This PR adds a few missing descriptions and homepages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

markuskowa
markuskowa reviewed Oct 8, 2019
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup.
I think the new convention is to put the URLs in quotation marks "".

@cko
Copy link
Member Author

cko commented Oct 8, 2019

@markuskowa I added the quotes and force-pushed the changes to have them in a single commit

maggesi
maggesi approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@maggesi maggesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All links works.
All descriptions looks good.

@markuskowa markuskowa merged commit c40d148 into NixOS:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa left review comments

@maggesi maggesi maggesi approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cko @maggesi @markuskowa