Turn on backpressure for blink::WebSocketStream sooner #19563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 8, 2019
Apply backpressure to blink::WebSocketChannel before the WebSocketStream handshake starts, rather than after it completes. This avoids a race condition where more of the first message is read than should be. Also fix flakiness in the external/wpt/websockets/stream-tentative/backpressure-receive.any.js by doubling the size of message used. BUG=1002780 Change-Id: I915c71a4b81b95375b7c4c584f7782d5336cba85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844911 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#703610}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1844911
branch
from
357b58b
to
cd0de17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply backpressure to blink::WebSocketChannel before the WebSocketStream
handshake starts, rather than after it completes. This avoids a race
condition where more of the first message is read than should be.
Also fix flakiness in the
external/wpt/websockets/stream-tentative/backpressure-receive.any.js by
doubling the size of message used.
BUG=1002780
Change-Id: I915c71a4b81b95375b7c4c584f7782d5336cba85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844911
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703610}