Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome 3.34.1 #70705

Merged
merged 38 commits into from Oct 8, 2019
Merged

Gnome 3.34.1 #70705

merged 38 commits into from Oct 8, 2019

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Oct 8, 2019

Motivation for this change
Things done

Staging updates will come in a separate pr.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor

We'll just say this point release was very needed and proactive 😄

@hedning
Copy link
Contributor Author

hedning commented Oct 8, 2019

Yeah, the zero releases tend have a few issues :/

Built everything (and a large part of the reverse dependencies). Think this is good to go tbh.

  • moved evince back to tarball as they now contain meson
  • removed gio-unix ld flag from gnome-terminal as that's fixed upstream
  • ran up a VM to check that gdm/gnome-session works correctly

@worldofpeace
Copy link
Contributor

@hedning Seems good to me also. Will run some checks now and probably merge shortly.

@hedning hedning merged commit 7757dd1 into NixOS:master Oct 8, 2019
@hedning
Copy link
Contributor Author

hedning commented Oct 8, 2019

gnome-shell and mutter is late updating, so we'll just do them in a separate pr.

@hedning hedning deleted the gnome-3.34.1 branch October 9, 2019 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants