Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-bloat: 0.8.3 -> 0.9.0 #70902

Merged
merged 1 commit into from Oct 12, 2019
Merged

cargo-bloat: 0.8.3 -> 0.9.0 #70902

merged 1 commit into from Oct 12, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Oct 10, 2019

Motivation for this change

Update cargo-bloat to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 10, 2019

@GrahamcOfBorg eval

jonringer
jonringer approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable works

[4 built, 3 copied (516.2 MiB), 186.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70902
1 package were build:
cargo-bloat

[nix-shell:/home/jon/.cache/nix-review/pr-70902]$ nix path-info -Sh ./results/cargo-bloat
/nix/store/lb151ca914jfb9yxlyq2dk3ig4li7hzk-cargo-bloat-0.9.0     27.5M

@jonringer
Copy link
Contributor

@GrahamcOfBorg build cargo-bloat

@jonringer jonringer merged commit 1658beb into NixOS:master Oct 12, 2019
@xrelkd xrelkd deleted the update/cargo-bloat branch October 12, 2019 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @c0bw3b @jonringer