Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common/sleep.py to resource-timing/sleep.py #19597

Merged
merged 1 commit into from Oct 17, 2019

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Oct 9, 2019

Part of #17913.


I was going to delete this seemingly unused file, but when I looked closer I found it was used by resource-timing/resource-timing-level1.sub.html, imported in resource-timing/SyntheticResponse.py.

I could be convinced that other tests may need this as well such that it should stay in common/, but right now it's not commonly used...

Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoavweiss yoavweiss merged commit 3e53064 into master Oct 17, 2019
@gsnedders gsnedders deleted the zcorpan/rm-common-sleep-py branch January 24, 2020 18:08
@gsnedders gsnedders restored the zcorpan/rm-common-sleep-py branch January 24, 2020 18:51
@foolip foolip deleted the zcorpan/rm-common-sleep-py branch April 14, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants