[Gecko Bug 1586909] Process anchor suppressions even when ignoring adjustments. #19561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we may keep the scroll anchor around and we may try to anchor to it later even though we should've really suppressed it completely. Maybe we should just call InvalidateAnchor() unconditionally from that code path, even if there are no suppressions pending... Differential Revision: https://phabricator.services.mozilla.com/D48456 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1586909 gecko-commit: befaa1098701a56142b4534c9cfae10a377cfce9 gecko-integration-branch: autoland gecko-reviewers: dholbert
wpt-pr-bot
approved these changes
Oct 7, 2019
MANUAL PUSH: bustage bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1586909 gecko-commit: 613e9a1a99f34df0fde97c5ed6c6b5ed268915d8 gecko-integration-branch: autoland
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we may keep the scroll anchor around and we may try to anchor to it
later even though we should've really suppressed it completely.
Maybe we should just call InvalidateAnchor() unconditionally from that code
path, even if there are no suppressions pending...
Differential Revision: https://phabricator.services.mozilla.com/D48456
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1586909
gecko-commit: befaa1098701a56142b4534c9cfae10a377cfce9
gecko-integration-branch: autoland
gecko-reviewers: dholbert