Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ultrastar-creator/ultrastar-manager: wrapQtAppsHook #70673

Merged

Conversation

Profpatsch
Copy link
Member

It was impossible to start them from a nix shell because they were not
wrapped.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Profpatsch If these are purely qt applications then they've already been packaged incorrectly if they fail at runtime.

A qt app should be called with libsForQt5.callPackage in all-packages.nix and use mkDerivation as opposed to stdenv.mkDerivation. And that's the qt specific deriver which automatically adds wrapQtAppsHook to nativeBuildInputs. Hence if this was packaged correctly there would be no need for such a change.

@Profpatsch
Copy link
Member Author

A qt app should be called with libsForQt5.callPackage in all-packages.nix and use mkDerivation as opposed to stdenv.mkDerivation. And that's the qt specific deriver which automatically adds wrapQtAppsHook to nativeBuildInputs. Hence if this was packaged correctly there would be no need for such a change.

Yeah, but I don’t really care, it has been working apart from that, and I don’t have the time to rewrite this.

@worldofpeace worldofpeace force-pushed the ultrastar-creator-manager-wrapQtAppHook branch from 14bfcb9 to ee8032c Compare October 8, 2019 11:16
@worldofpeace
Copy link
Contributor

@Profpatsch Umm, I guess I'll just push the changes then...

@worldofpeace worldofpeace merged commit f05062e into NixOS:master Oct 8, 2019
@worldofpeace
Copy link
Contributor

backported in 24d8fb8 8b4fbb8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants