Update scroll to text feature detectability API #19610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 9, 2019
Update the feature detectability API to window.location.fragmentDirective per WICG/scroll-to-text-fragment#19 Also updated web platform tests and confirmed tests pass. Bug: 1000308 Change-Id: Ib2391abe3d142d57cea61840e721ed35c81089af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850364 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#705010}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1850364
branch
from
0373809
to
5ef8567
Compare
|
Flaky on /scroll-to-text-fragment/scroll-to-text-fragment.html but appears to be an existing flaky. Please admin merge @foolip |
|
Will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the feature detectability API to
window.location.fragmentDirective per
WICG/scroll-to-text-fragment#19
Also updated web platform tests and confirmed tests pass.
Bug: 1000308
Change-Id: Ib2391abe3d142d57cea61840e721ed35c81089af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850364
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705010}