Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore commandOutput resources #1203

Merged
merged 1 commit into from Oct 11, 2019

Conversation

dsg22
Copy link
Contributor

@dsg22 dsg22 commented Oct 10, 2019

The customCommand resource is no longer usable since acb2ab1.

I'm not sure if this is intentional or if it was accidentally removed from eval-machine-info.nix during the plugin restructuring. Assuming it was not intentional, this PR re-enables it.

After applying, tests/functional/single_machine_outputs.nix should be deployable.

@AmineChikhaoui AmineChikhaoui merged commit a3f4d1b into NixOS:master Oct 11, 2019
@AmineChikhaoui
Copy link
Member

Thanks. Though the test expression doesn't work out of the box, I think we need to have a default value for resources.commandOutput.<name>.value so that the first eval works which evaluates the network info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants