kio-gdrive: init at version 1.2.7 #70754
Conversation
There was a problem hiding this comment.
signon-ui seems to fail to build
Project MESSAGE: ==== NOTE: Remember to add your API headers into `headers.files' for installation!
Project ERROR: accounts-qt5 development package not found
make[1]: *** [Makefile:44: sub-signon-ui-pro-make_first] Error 3
make[1]: Leaving directory '/build/signon-ui-3acb654/src'
make: *** [Makefile:92: sub-src-make_first-ordered] Error 2
builder for '/nix/store/cx6wbs1lrm47f4jzq09bgpj56xyqs0j7-signon-ui.drv' failed with exit code 2
error: build of '/nix/store/cx6wbs1lrm47f4jzq09bgpj56xyqs0j7-signon-ui.drv' failed
|
accounts-qt5 is inside buildInputs, so the error is seems weird to me. And it works in my environment... Would you kindly give me more information so I could try to reproduce it? |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/how-to-add-a-new-kde-package-for-kio-gdrive/5539/2 |
konstantinous
requested review from
andir,
basvandijk,
cdepillabout,
edolstra,
FRidh,
infinisil,
matthewbauer,
nbp and
peti
as code owners
|
Not exactly, sorry. I meant moving the new changes to the respective
The idea is that the history of a PR (like fixing mistakes) shouldn't be preserved when merged into master. |
|
Is there anything else I can do to help the merge happen? |
|
Sorry, I forgot about this PR: unfortunately github doesn't send notification on new commits. |
|
@jonringer can you finish your review? |
Add signong binary in order to use online accounts integration in the future
Add signon-ui binary in order to use KDE online accounts integration in the future
Add oauth2 plugin for signond daemon to authenticate via google api
Add kaccounts-integration package from KDE applications in order to enable online accounts integration
Add kaccounts-providers from KDE applications in order to enable online accounts integration in the future
Add signon-kwallet-extension from KDE applications in order to secure signon information
Add ktp-accounts-kcm from KDE applications in order to enable KDE online accounts integration
Add google drive integration for KDE
It seems the only way to inject variables into user environment since sidnon daemon requires a path to it's plugins and extensions. By default it looks for plugins inside the directory in which it's binary is located
Required by kde kcm kaccounts module
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
@konstantinous Are you still working on this? I would like to help you get this merged. Hoever it needs a rebase and most probably an update of the mentioned components. |
stale
bot
removed
the
2.status: stale
I believe kio-gdrive was added in #122040, so perhaps this is obsolete now. |
I had to add signon, signon-ui, kaccounts-integration and providers
packages to be able to build kio-gdrive ( one of the packages from #62168 )
Package works well on my laptop. Signond daemon is probably not able to find it's plugins installed into user profile. However, it doesn't affect kio-gdrive itself.
Motivation for this change
Add google drive integration to KDE dolphin and other kio aware apps.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)