New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pantheon: use latest vala #70890
pantheon: use latest vala #70890
Conversation
elementary OS's ecosystem is curated around Ubuntu's LTS releases. This means the development platform for their curated applications always includes a LTS version of vala (in 18.04 it's 0.40). Because of how vala development works it suspect some of these applications to have serious issues if complied with the latest vala. However in the past year or so, for Pantheon at least, I don't think their applications will have much issues with latest vala, and if there is I don't think they'd be difficult to fix. In this single regard they've become more responsive since their preferred language is vala. As for the curated applications I have less of this confidence in. So I'd have to be accept less applications, but that's something I'm willing to compromise on. And this is easily reversible or could be done on a per-application basis. And nix already makes this trivial.
@GrahamcOfBorg test pantheon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like a good idea.
I just need a clarification: let's say a curated application don't compile with the latest vala, should we submit it with a specific vala version (e.g. vala_0_40) or should we try to fix it to work with the latest vala ?
So if it doesn't compile with latest vala we should firstly submit an issue upstream with the issues. And that really depends if the particular author wants to take action to support third-parties, i.e they won't get revenue directly from Appcenter. Though I've never ran into that being an issue. |
Still waiting for release NixOS#69052
Motivation for this change
elementary OS's ecosystem is curated around Ubuntu's LTS releases.
This means the development platform for their curated applications
always includes a LTS version of vala (in 18.04 it's 0.40).
Because of how vala development works I suspect some of these
applications to have serious issues if complied with the latest vala.
However in the past year or so, for Pantheon at least, I don't think
their applications will have much issues with latest vala, and if there
is I don't think they'd be difficult to fix. In this single regard they've
become more responsive since their preferred language is vala.
As for the curated applications I have less of this confidence in.
So I'd have to be accept less applications, but that's something
I'm willing to compromise on. And this is easily reversible or
could be done on a per-application basis. And nix already makes
this trivial.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @