Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3: always use latest vala #70891

Merged
merged 3 commits into from Oct 10, 2019
Merged

gnome3: always use latest vala #70891

merged 3 commits into from Oct 10, 2019

Conversation

worldofpeace
Copy link
Contributor

I forgot to do this when adding vala_0_46

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor Author

@jtojnar Should we even keep this alias?

@jtojnar
Copy link
Contributor

jtojnar commented Oct 10, 2019

IMHO we should move this into the aliases section and point it to pkgs.vala. GNOME should be always using latest.

@worldofpeace worldofpeace changed the title gnome3: use vala_0_46 gnome3: always use latest vala Oct 10, 2019
@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg eval

@jtojnar
Copy link
Contributor

jtojnar commented Oct 10, 2019

And we also need to remove the use of aliases. Not sure why does not borg catch it.

@worldofpeace worldofpeace changed the base branch from master to staging October 10, 2019 16:24
@worldofpeace
Copy link
Contributor Author

worldofpeace commented Oct 10, 2019 •
edited

Don't know what's up with ofborg with merging. This works to staging just fine.

@GrahamcOfBorg eval

@worldofpeace worldofpeace merged commit 87ed3e8 into NixOS:staging Oct 10, 2019
@worldofpeace worldofpeace deleted the gnome3-fixup-vala branch October 10, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: documentation 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jtojnar