Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mycli: 1.19.0 -> 1.20.1 #70834

Merged
merged 1 commit into from
Oct 9, 2019
Merged

mycli: 1.19.0 -> 1.20.1 #70834

merged 1 commit into from
Oct 9, 2019
+3 −450

Conversation

jojosch
Copy link
Member

@jojosch jojosch commented Oct 9, 2019

Motivation for this change

The package did not build anymore:

Requirement already satisfied: configobj>=5.0.5 in /nix/store/j85bgcwp8kgbn7pjz9h5iycvslq42djj-python3.7-configobj-5.0.6/lib/python3.7/site-packages (from mycli==1.19.0) (5.0.6)
Requirement already satisfied: PyMySQL>=0.9.2 in /nix/store/vrgqwdq8w17n7d6l3acmni67zryygnlk-python3.7-PyMySQL-0.9.3/lib/python3.7/site-packages (from mycli==1.19.0) (0.9.3)
Requirement already satisfied: Pygments>=1.6 in /nix/store/v7n8sbpknx2s8yxl3a2dxjzpw15px03q-python3.7-Pygments-2.4.2/lib/python3.7/site-packages (from mycli==1.19.0) (2.4.2)
Requirement already satisfied: cli-helpers[styles]>=1.0.1 in /nix/store/31gqi05ljs0k9f2dkq6y7vdrwh7gvr1g-python3.7-cli_helpers-1.2.1/lib/python3.7/site-packages (from mycli==1.19.0) (1.2.1)
Collecting sqlparse<0.3.0,>=0.2.2 (from mycli==1.19.0)
  ERROR: Could not find a version that satisfies the requirement sqlparse<0.3.0,>=0.2.2 (from mycli==1.19.0) (from versions: none)
ERROR: No matching distribution found for sqlparse<0.3.0,>=0.2.2 (from mycli==1.19.0)
builder for '/nix/store/636a8bjb1kfyshrdvrd36d5r17nn0w7b-mycli-1.19.0.drv' failed with exit code 1
error: build of '/nix/store/636a8bjb1kfyshrdvrd36d5r17nn0w7b-mycli-1.19.0.drv' failed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@jojosch
mycli: 1.19.0 -> 1.20.1

Unverified

The email in this signature doesn’t match the committer email.
GPG key ID: 063CCCAD04182D32
Expired
Learn about vigilant mode
69894ed
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 9, 2019
jonringer
jonringer approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable works
leaf package

[3 built, 4 copied (0.7 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70834
1 package were build:
mycli

@jonringer
Copy link
Contributor

@GrahamcOfBorg build mycli

@jonringer jonringer merged commit 8275ac3 into NixOS:master Oct 9, 2019
@jojosch jojosch deleted the mycli-1.20.1 branch October 9, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jojosch @jonringer