Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zstd --no-progress in manifest_build.py #19568

Merged
merged 2 commits into from Oct 8, 2019
Merged

Use zstd --no-progress in manifest_build.py #19568

merged 2 commits into from Oct 8, 2019

Conversation

foolip
Copy link
Member

@foolip foolip commented Oct 8, 2019

gzip and bzip2 are silent by default.

gzip and bzip2 are silent by default.
@gsnedders
Copy link
Member

Per the zstd help, this suppresses warnings? What warnings are we getting? I can see why might want --no-progress, but -q?

@foolip
Copy link
Member Author

foolip commented Oct 8, 2019

We don't get any warnings, I just wanted to suppress progress. I'll go with --no-progress instead.

@foolip foolip changed the title Use zstd -q in manifest_build.py Use zstd --no-progress in manifest_build.py Oct 8, 2019
@foolip foolip merged commit 1dd29f0 into master Oct 8, 2019
@foolip foolip deleted the foolip/zstd-q branch October 8, 2019 14:23
@foolip
Copy link
Member Author

foolip commented Oct 8, 2019

Oh no, the argument wasn't supported on the version of zstd used in CI:
https://github.com/web-platform-tests/wpt/commit/1dd29f0138509c085c01df7ec3214231d28853b8/checks?check_suite_id=256341241

Reverting!

foolip added a commit that referenced this pull request Oct 8, 2019
foolip added a commit that referenced this pull request Oct 8, 2019
jugglinmike pushed a commit that referenced this pull request Oct 8, 2019
* [GitHub Actions] dry run the manifest workflow on pull requests

To avoid mishaps like #19568 (comment).

* Run as much code as possible before exiting dry run

* Update manifest_build.py

* Exit before `get_pr` when dry running manifest_build.py
@foolip foolip restored the foolip/zstd-q branch October 9, 2019 07:40
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 24, 2019
…rkflow on pull requests, a=testonly

Automatic update from web-platform-tests
[GitHub Actions] dry run the manifest workflow on pull requests (#19573)

* [GitHub Actions] dry run the manifest workflow on pull requests

To avoid mishaps like web-platform-tests/wpt#19568 (comment).

* Run as much code as possible before exiting dry run

* Update manifest_build.py

* Exit before `get_pr` when dry running manifest_build.py

--

wpt-commits: ca1a7a206f4ff0f8de1169b183b3b2474850a7c0
wpt-pr: 19573
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Oct 24, 2019
…rkflow on pull requests, a=testonly

Automatic update from web-platform-tests
[GitHub Actions] dry run the manifest workflow on pull requests (#19573)

* [GitHub Actions] dry run the manifest workflow on pull requests

To avoid mishaps like web-platform-tests/wpt#19568 (comment).

* Run as much code as possible before exiting dry run

* Update manifest_build.py

* Exit before `get_pr` when dry running manifest_build.py

--

wpt-commits: ca1a7a206f4ff0f8de1169b183b3b2474850a7c0
wpt-pr: 19573
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 27, 2019
…rkflow on pull requests, a=testonly

Automatic update from web-platform-tests
[GitHub Actions] dry run the manifest workflow on pull requests (#19573)

* [GitHub Actions] dry run the manifest workflow on pull requests

To avoid mishaps like web-platform-tests/wpt#19568 (comment).

* Run as much code as possible before exiting dry run

* Update manifest_build.py

* Exit before `get_pr` when dry running manifest_build.py

--

wpt-commits: ca1a7a206f4ff0f8de1169b183b3b2474850a7c0
wpt-pr: 19573

UltraBlame original commit: 4a44d793b764ce4c7e77db80894eecefb8ea82ea
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 27, 2019
…rkflow on pull requests, a=testonly

Automatic update from web-platform-tests
[GitHub Actions] dry run the manifest workflow on pull requests (#19573)

* [GitHub Actions] dry run the manifest workflow on pull requests

To avoid mishaps like web-platform-tests/wpt#19568 (comment).

* Run as much code as possible before exiting dry run

* Update manifest_build.py

* Exit before `get_pr` when dry running manifest_build.py

--

wpt-commits: ca1a7a206f4ff0f8de1169b183b3b2474850a7c0
wpt-pr: 19573

UltraBlame original commit: 4a44d793b764ce4c7e77db80894eecefb8ea82ea
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 27, 2019
…rkflow on pull requests, a=testonly

Automatic update from web-platform-tests
[GitHub Actions] dry run the manifest workflow on pull requests (#19573)

* [GitHub Actions] dry run the manifest workflow on pull requests

To avoid mishaps like web-platform-tests/wpt#19568 (comment).

* Run as much code as possible before exiting dry run

* Update manifest_build.py

* Exit before `get_pr` when dry running manifest_build.py

--

wpt-commits: ca1a7a206f4ff0f8de1169b183b3b2474850a7c0
wpt-pr: 19573

UltraBlame original commit: 4a44d793b764ce4c7e77db80894eecefb8ea82ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants