Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obs-wlrobs: init at 20191008 #70750

Merged
merged 1 commit into from Oct 8, 2019
Merged

obs-wlrobs: init at 20191008 #70750

merged 1 commit into from Oct 8, 2019

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Oct 8, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer reviewed Oct 8, 2019
View reviewed changes
pkgs/applications/video/obs-studio/wlrobs.nix Show resolved Hide resolved
pkgs/applications/video/obs-studio/wlrobs.nix
Comment on lines +21 to +23
preBuild = ''
cd Release
'';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternative would be

Suggested change
preBuild = ''
cd Release
'';
sourceRoot = "hg-archive/Release";

not sure which one is better :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the source isn't in hg-archive/Release, and just the build tooling lives in that dir. That is why I picked cd instead... Not sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it during the review, and it was able to build. But I don't feel super strong about this. :)

pkgs/applications/video/obs-studio/wlrobs.nix Outdated Show resolved Hide resolved
@grahamc
Copy link
Member Author

grahamc commented Oct 8, 2019

Fixed up most feedback :)

@grahamc grahamc merged commit 21597ed into NixOS:master Oct 8, 2019
@grahamc grahamc deleted the wlrobs branch October 8, 2019 19:08
This was referenced Jan 12, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grahamc @jonringer