The size of OverflowClipRect is negative #19566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 8, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1840492
branch
2 times, most recently
from
dec2f50
to
48d958a
Compare
When scrollbar wider than the scrollar, the size of OverflowClipRect is negative which will affect the value of scroll offset. This patch make the size non-negative. Bug: 987566 Change-Id: I7fa80e4a17bc48303713a1a191230d0b3e7d0dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840492 Commit-Queue: cathie chen <cathiechen@igalia.com> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703662}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1840492
branch
from
48d958a
to
d11bbbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scrollbar wider than the scrollar, the size of OverflowClipRect
is negative which will affect the value of scroll offset. This patch
make the size non-negative.
Bug: 987566
Change-Id: I7fa80e4a17bc48303713a1a191230d0b3e7d0dd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840492
Commit-Queue: cathie chen <cathiechen@igalia.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703662}