Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t override system PATH in nix-profile.sh #3135

Closed

Conversation

matthewbauer
Copy link
Member

Sometimes --with-coreutils-bin= will be set to something like /bin or
/usr/bin. This usually works out okay, but on some systems the
different coreutils commands are in different directories. We don’t
really know what these directories will look like ahead of time, so
need to be a little more forgiving in the profile script. To avoid
causing issues, we can just prefix system PATH instead of overwriting
it altogether. This should help with #3127.

Sometimes --with-coreutils-bin= will be set to something like /bin or
/usr/bin. This usually works out okay, but on some systems the
different coreutils commands are in different directories. We don’t
really know what these directories will look like ahead of time, so
need to be a little more forgiving in the profile script. To avoid
causing issues, we can just prefix system PATH instead of overwriting
it altogether. This should help with NixOS#3127.
@matthewbauer matthewbauer changed the title Don’t override system PATH Don’t override system PATH in nix-profile.sh Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant