Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundler: 1.17.2 -> 1.17.3 #70860

Merged
merged 1 commit into from Oct 9, 2019
Merged

bundler: 1.17.2 -> 1.17.3 #70860

merged 1 commit into from Oct 9, 2019

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Oct 9, 2019

Motivation for this change

This wasn't ported to release-19.09 when #70216 was merged, resulting in warnings from gitlab.

Things done
  • Tested by building and deploying GitLab
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @alyssais @globin @flokli

@talyz
bundler: 1.17.2 -> 1.17.3
66a44d4 
Extracted from NixOS#70216.

(cherry picked from commit 96a1dba)
@alyssais alyssais merged commit 4bf2127 into NixOS:release-19.09 Oct 9, 2019
@alyssais
Copy link
Member

alyssais commented Oct 9, 2019

Sorry about that. Should have done it when I cherry-picked.

@talyz talyz deleted the bundler-1_17_3 branch June 16, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais alyssais is a code owner

@zimbatm zimbatm Awaiting requested review from zimbatm zimbatm is a code owner

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@talyz @alyssais