Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envelope: init at 0.0.4 #70763

Merged
merged 1 commit into from Oct 12, 2019
Merged

envelope: init at 0.0.4 #70763

merged 1 commit into from Oct 12, 2019

Conversation

xiorcale
Copy link
Contributor

@xiorcale xiorcale commented Oct 8, 2019

Motivation for this change

Add more curated apps from Elementary OS app store for Pantheon Desktop.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from worldofpeace October 8, 2019 17:38
@mmahut
Copy link
Member

mmahut commented Oct 10, 2019

@GrahamcOfBorg build envelope

@xiorcale xiorcale force-pushed the envelope branch 3 times, most recently from 0ff182b to 4c38a95 Compare October 10, 2019 14:20
@mmahut
Copy link
Member

mmahut commented Oct 11, 2019

@GrahamcOfBorg build envelope

worldofpeace
worldofpeace reviewed Oct 11, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add doCheck = true; so we can run the test?

@xiorcale
Copy link
Contributor Author

Can you add doCheck = true; so we can run the test?

* https://github.com/cjfloss/envelope/blob/master/tests/meson.build#L33

Interestingly the test failed to validate the appdata file. I updated the PR with the failed test but I have no clue about what I should do to correct it.

@ofborg ofborg bot requested a review from worldofpeace October 12, 2019 09:26
@worldofpeace
Copy link
Contributor

worldofpeace commented Oct 12, 2019 •
edited

Can you add doCheck = true; so we can run the test?

* https://github.com/cjfloss/envelope/blob/master/tests/meson.build#L33

Interestingly the test failed to validate the appdata file. I updated the PR with the failed test but I have no clue about what I should do to correct it.

So probably our appstream-glib is out of date or their appstream file needs corrections.
Will look into this.

@worldofpeace worldofpeace mentioned this pull request Oct 12, 2019
Merged
@xiorcale @worldofpeace
envelope: init at 0.0.4
5075996 
Co-authored-by: worldofpeace <worldofpeace@protonmail.ch>
@worldofpeace
Copy link
Contributor

@Kjuvi Opened cjfloss/envelope#59 for the issues with appdata validation.
It was set to a strict validation, and it wanted network access which is disallowed in the nix sandbox.

@worldofpeace worldofpeace merged commit 018bba8 into NixOS:master Oct 12, 2019
@xiorcale xiorcale deleted the envelope branch October 13, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xiorcale @mmahut @worldofpeace