Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/mullvad-vpn: add service #70762

Merged
merged 1 commit into from Apr 1, 2020
Merged

nixos/mullvad-vpn: add service #70762

merged 1 commit into from Apr 1, 2020

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Oct 8, 2019 •
edited

Motivation for this change

mullvad-vpn package is mostly useless without it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@KamilaBorowska
nixos/mullvad-vpn: add service
89f5dc2 
mullvad-vpn package is mostly useless without it.
@KamilaBorowska KamilaBorowska mentioned this pull request Jan 21, 2020
Closed
10 tasks
@06kellyjac
Copy link
Member

06kellyjac commented Feb 14, 2020 •
edited

I'd really appreciate it if someone could review this PR.
It'd be a very useful addition for me. 🙂

This was referenced Mar 27, 2020
Merged
Merged
@marsam marsam merged commit c47ec30 into NixOS:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KamilaBorowska @06kellyjac @marsam @Janik-Haag