Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ciso8601: init at 2.1.1 #70837

Closed
wants to merge 4 commits into from
Closed

pythonPackages.ciso8601: init at 2.1.1 #70837

wants to merge 4 commits into from
+40 −0

Conversation

liamdiprose
Copy link
Contributor

@liamdiprose liamdiprose commented Oct 9, 2019 •
edited
Loading

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Ubuntu 18.04
    • other Linux distributions
  • Tested via one or more NixOS test(s) not applicable?
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Liam Diprose added 4 commits October 9, 2019 20:28
pythonPackages.ciso8601: init at 2.1.1

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
GPG key ID: 78AC5AE55A47A65B
Verified
Learn about vigilant mode
4237c29
pythonPackages.ciso8601: init at 2.1.1
c11de1d
pythonPackages.ciso8601: init at 2.1.1
7988298
Add ciso8601 to top-level
80c3112
@liamdiprose liamdiprose requested a review from FRidh as a code owner October 9, 2019 08:08
@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 9, 2019
jonringer
jonringer approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
module seems to work

[4 built, 4 copied (1.1 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70837
2 package were build:
python27Packages.ciso8601 python37Packages.ciso8601

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.ciso8601 python37Packages.ciso8601

@jonringer
Copy link
Contributor

do you mind rebasing this branch on origin/master?

@jonringer
Copy link
Contributor

also, please squash all the commits into one.

git reset HEAD~3
git commit -a --amend --no-edit
git push force liamdiprose ciso8601-2.1.1

@jonringer
Copy link
Contributor

changes are also present in #70840

@liamdiprose
Copy link
Contributor Author

Closing in favor of #70840

@liamdiprose liamdiprose closed this Oct 9, 2019
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liamdiprose @jonringer @Janik-Haag