Added package libvmaf. #70692
Added package libvmaf. #70692
Conversation
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
labels
|
please refactor the addition of you as a maintainer into a separate commit :) |
| installPhase = '' | ||
| make INSTALL_PREFIX=$out install | ||
| ''; |
There was a problem hiding this comment.
this is the default install phase, you can remove
There was a problem hiding this comment.
@jonringer Are you sure? Without passing that INSTALL_PREFIX as a parameter to make like that it installs in /usr/local
There was a problem hiding this comment.
I apologize, make PREFIX=${placeholder "out"}" install is the default installPhase. what I meant was
makeFlags = [ "INSTALL_PREFIX=${placeholder "out"}" ];
| sha256="13ajbcidngjvgl0rr7l0mb43h651p5pqj3d1linrfk9c222b9fs3"; | ||
| }; | ||
|
|
||
| buildInputs = [ autoconf automake intltool libtool pkgconfig ]; |
There was a problem hiding this comment.
if they are just needed for the build, then they should be nativeBuildInputs. buildInputs is usually for package that you need to link against for runtime.
| buildInputs = [ autoconf automake intltool libtool pkgconfig ]; | |
| nativeBuildInputs = [ autoconf automake intltool libtool pkgconfig ]; |
There was a problem hiding this comment.
Also, you could probably replace all of that with [ autoreconfHook pkgconfig ];
made changes recommended by @jonringer
| rev = "v${version}"; | ||
| sha256="13ajbcidngjvgl0rr7l0mb43h651p5pqj3d1linrfk9c222b9fs3"; | ||
| }; | ||
|
|
There was a problem hiding this comment.
not a big deal, but i would also add multiple outputs
outputs = [ "out" "dev" ];
cleans up the outputs a bit, but not by much
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
libvmaf: init at 1.3.15 ffmpeg-full: Add libvmaf support Co-Authored-By: Jon <jonringer@users.noreply.github.com>
|
I'll create a new one shortly - this is becoming a mess |
Motivation for this change
VMAF is netflix's video quality scoring library.
FFmpeg supports it as a build option. This is the first of two PR - the 2nd being of course for FFmpeg itself.
Things done
Created package file. Tested on Linux (Ubuntu). It's a standard build though, nothing fancy here.
Nothing pre-existing depends on this package, but I've tested of course that FFmpeg builds with it when the relevant option is enabled.
Added myself as a maintainer.
Followed the contribution guide as best as I could.