gstreamer 1.16.1 #70690
Merged
gstreamer 1.16.1 #70690
+781
−395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requesting reviews guided by GitHub's unmatched wisdom in suggested reviewers! ;) |
jtojnar
requested changes
Oct 15, 2019
There was a problem hiding this comment.
According to release notes:
- bad: should build with opencv4
- bad: Does not newly added
colormanagementmeson option break stuff? - vaapi: the patch seems to have been backported to 1.16.1: https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/commit/8c11de79260105c5ad38454c7766290e6994fa11
|
After swithching to opencv4, I am getting the following warnings: Though, they do not seem to affect build. |
jtojnar
force-pushed
the
update/gstreamer-1.16.1
branch
from
121b93b to
25ab32f
Compare
|
Clean ups in a fixup commits. Trying to see if base build on Darwin with Meson now. |
|
If you are looking for Darwin fixes, consider the top commit of #60922. |
11 tasks
|
@jtojnar Glorious cleanups 👍 Taking a look. |
|
@GrahamcOfBorg build gst_all_1 |
|
mesonbuild/meson#5980 fixed but now there is |
|
Works for my use case (SRT-based screen sharing). I ran in 2 terminals: For my reference, there are apparently also some SRT related improvements in this release's changelog:
|
jtojnar
force-pushed
the
update/gstreamer-1.16.1
branch
from
a92196e to
f1949bb
Compare
|
Moved the meson fix to meson proper and fully dropped the autotools bit from base. @NixOS/darwin-maintainers any idea how to fix the |
* format withn nixpkgs-fmt * drop unnecessary flags * do not propagate gupnp-igd (it is only in Requires.private)
tests are failing there FAIL: test-is-public ==================== valgrind: mmap-FIXED(0x7fff5f400000, 8388608) failed in UME (load_unixthread1) with error 22 (Invalid argument). FAIL test-is-public (exit status: 1) FAIL: test-is-public-all ======================== valgrind: mmap-FIXED(0x7fff5f400000, 8388608) failed in UME (load_unixthread1) with error 22 (Invalid argument). FAIL test-is-public-all (exit status: 1) FAIL: test-is-cookie-domain-acceptable ====================================== valgrind: mmap-FIXED(0x7fff5f400000, 8388608) failed in UME (load_unixthread1) with error 22 (Invalid argument). FAIL test-is-cookie-domain-acceptable (exit status: 1) FAIL: test-is-public-builtin ============================ valgrind: mmap-FIXED(0x7fff5f400000, 8388608) failed in UME (load_unixthread1) with error 22 (Invalid argument). FAIL test-is-public-builtin (exit status: 1) FAIL: test-registrable-domain ============================= valgrind: mmap-FIXED(0x7fff5f400000, 8388608) failed in UME (load_unixthread1) with error 22 (Invalid argument). FAIL test-registrable-domain (exit status: 1)
Commit be38210 broke evaluation on Darwin because it added these unconditional buildInputs that don't evaluate on Darwin: libnice librdf lilv lv2 serd sord sratom This commit fixes it, and also fixes recently-added new dependencies for other packages accordingly. It further fixes the build of many gstreamer packages on Darwin.
Fixes building gst_all_1.gst-plugins-good. Patch backported from 0.52.0.
jtojnar
force-pushed
the
update/gstreamer-1.16.1
branch
from
f1949bb to
071d25a
Compare
|
@GrahamcOfBorg build gst_all_1.gst-editing-services gst_all_1.gst-plugins-base gst_all_1.gst-rtsp-server gst_all_1.gstreamer gst_all_1.gst-libav gst_all_1.gst-plugins-good gst_all_1.gst-vaapi gst_all_1.gstreamermm gst_all_1.gst-plugins-bad gst_all_1.gst-plugins-ugly gst_all_1.gst-validate |
ofborg
bot
added
10.rebuild-darwin: 501+
10.rebuild-darwin: 2501-5000
and removed
10.rebuild-darwin: 101-500
labels
|
The failures appear to be unrelated. Let’s merge and see. |
|
Thanks! |
jtojnar
added a commit
to jtojnar/nixpkgs
that referenced
this pull request
Nov 27, 2019
Fixes regression from NixOS#70690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)