Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 03ba73585671
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: fba9144f92f5
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Oct 5, 2019

  1. linux_5_2, linux_5_3: fixing nondeterminism 

    In 5.2 kernel a new mechanism was introduced which embeds the kernel
headers in the kernel image and exposes them in procfs for simplified
use by userland tools.

It was introduced in
torvalds/linux@43d8ce9
and later modified a bit in
torvalds/linux@f7b101d

The archive containing the header files had nondeterminism through the
header files metadata - specifically `mtime`, but I also decided to
normalize some other aspects just in case.

In our default setup we currently compile this as a module, so to expose
the headers to test the functionality `kheaders` needs to be loaded.

See https://lkml.org/lkml/2019/10/4/1036 and
https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/commit/?h=fixes&id=2cc99c9cdc8fde5e92e34f9655829449cebd3e00

I commented out the documentation part of the patch to make it cleanly apply to
5.2 and 5.3, see remark in the patch itself.
    @d-goldin
    d-goldin committed Oct 5, 2019
    Copy the full SHA
    bdccffa View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2019

  1. Merge pull request #69222 from d-goldin/fix_linux_5_determinism 

    linux_5_2, linux_5_3: fixing nondeterminism
    @globin
    globin committed Oct 8, 2019
    Copy the full SHA
    fba9144 View commit details
    Browse the repository at this point in the history