Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spotifyd: 0.2.18 -> 0.2.19 #70697

Merged
merged 2 commits into from Oct 10, 2019
Merged

spotifyd: 0.2.18 -> 0.2.19 #70697

merged 2 commits into from Oct 10, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 8, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

@anderslundstedt anderslundstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments and questions:

  • spotifyd --version outputs spotifyd 0.2.18. As far as I can tell upstream forgot to bump the version before release.

  • Did you check that the spotifyd service module still works as expected?

  • Perhaps add yourself as maintainer for the spotifyd service module as well (if you do use it)?

@marsam
Copy link
Contributor Author

marsam commented Oct 10, 2019

Thanks for reviewing

spotifyd --version outputs spotifyd 0.2.18. As far as I can tell upstream forgot to bump the version before release.

yeah, it seems like the version is behind of the released tag Spotifyd/spotifyd@v0.2.18...v0.2.19

Did you check that the spotifyd service module still works as expected?

yes, it seem to work

Perhaps add yourself as maintainer for the spotifyd service module as well (if you do use it)?

I don't use the module (yet)

@anderslundstedt
Copy link
Contributor

Alright, everything looks good then!

@marsam marsam merged commit 38070d5 into NixOS:master Oct 10, 2019
@marsam marsam deleted the update-spotifyd branch October 10, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants