flamegraph: 2017-07-01 -> 2019-02-16 #70876
Merged
+12
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build flamegraph |
c0bw3b
reviewed
Oct 15, 2019
c0bw3b
reviewed
Oct 15, 2019
c0bw3b
reviewed
Oct 15, 2019
| @@ -21,7 +21,7 @@ stdenv.mkDerivation { | |||
|
|
|||
| meta = with stdenv.lib; { | |||
| license = licenses.cddl; | |||
There was a problem hiding this comment.
Suggested change
| license = licenses.cddl; | |
| license = with licenses; [ asl20 cddl gpl2Plus ]; |
Looking at some of the scripts' headers it seems they come under one of these licenses.
c0bw3b
reviewed
Oct 15, 2019
|
When overriding an entire phase, it's best practice to call pre- and post- hooks in case they are needed later on. installPhase = ''
runHook preInstall
[...]
runHook postInstall
''; |
|
@c0bw3b I implemented the proposed changes and updated the PR. |
|
@GrahamcOfBorg build flamegraph |
c0bw3b
approved these changes
Oct 17, 2019
|
Thanks @cko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Updating flamegraph
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)stackcollapse-perf.plandflamegraph.plnix path-info -Sbefore and after)