Using device serial when using adb. #19583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Oct 8, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1845486
branch
from
cf36dcc
to
9f475f0
Compare
The Android device serial number, specified by the --device-serial
command-line option, was unused by the android_webview wptrunner.
This resulted in adb failing with the following error:
adb wait-for-device
error: more than one device/emulator
Bug: None
Change-Id: I85e236297d7e83950ac26a9283bdad4ef642d62c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845486
Commit-Queue: Chris Mumford <cmumford@google.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704747}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1845486
branch
from
9f475f0
to
0c27d43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Android device serial number, specified by the --device-serial
command-line option, was unused by the android_webview wptrunner.
This resulted in adb failing with the following error:
Bug: None
Change-Id: I85e236297d7e83950ac26a9283bdad4ef642d62c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845486
Commit-Queue: Chris Mumford <cmumford@google.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704747}