Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

u-boot: Add ROC-PC-RK3399 build #70794

Merged
merged 1 commit into from Jun 1, 2020
Merged

u-boot: Add ROC-PC-RK3399 build #70794

merged 1 commit into from Jun 1, 2020

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Oct 8, 2019 •
edited

Builds on #70793

Things done
Things done
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ✔️ NixOS
    • 🔲 macOS
    • 🔲 other Linux distributions
  • 🔲 Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • ✔️ Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • ✔️ Tested execution of all binary files (usually in ./result/bin/)
  • 🔲 Determined the impact on package closure size (by running nix path-info -S before and after)
  • 🔲 Ensured that relevant documentation is up to date
  • ✔️ Fits CONTRIBUTING.md.

This was verified to boot and run on hardware. Though the kernel was not booting, it's not because of the u-boot build AFAIK.

@samueldr samueldr mentioned this pull request Oct 8, 2019
Merged
@samueldr
Copy link
Member Author

samueldr commented Oct 8, 2019

Oops, wanted to open this as DRAFT, it depends on the other PR to be merged in first.

@ofborg ofborg bot requested review from dezgeg and lopsided98 October 8, 2019 22:01
@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@samueldr samueldr changed the title u-boot: Add ROC-RK3399-PC build u-boot: Add ROC-PC-RK3399 build Jun 1, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@samueldr samueldr merged commit 4a4adb2 into NixOS:master Jun 1, 2020
@samueldr samueldr deleted the u-boot/roc-rk3399-pc branch June 1, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dezgeg dezgeg Awaiting requested review from dezgeg

@lopsided98 lopsided98 Awaiting requested review from lopsided98

Assignees
No one assigned
Labels
2.status: work-in-progress 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0 11.by: package-maintainer
Projects
No open projects
NixOS on ARM
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@samueldr