Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing Android device serial to chromedriver. #19582

Merged
merged 1 commit into from Oct 10, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Oct 8, 2019

The Android device serial number, specified by the --device-serial
command-line option, was never passed to the chromedriver server.
This resulted in chromedriver always using the first device or
emulator.

Bug: None
Change-Id: I1a4cb1c45739f24da5ea0f6cfb3726c84ff68fa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848264
Commit-Queue: Chris Mumford <cmumford@google.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704795}

@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Oct 8, 2019
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

The Android device serial number, specified by the --device-serial
command-line option, was never passed to the chromedriver server.
This resulted in chromedriver always using the first device or
emulator.

Bug: None
Change-Id: I1a4cb1c45739f24da5ea0f6cfb3726c84ff68fa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848264
Commit-Queue: Chris Mumford <cmumford@google.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704795}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chromium-export infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants