Fugu: Use Display mojom and extend Screen interface for Screen Enumeration #19606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 9, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1842339
branch
6 times, most recently
from
cf700c7
to
bd792d8
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1842339
branch
6 times, most recently
from
aec4907
to
139f20c
Compare
…ation Update code to better match the latest Screen Enumeration proposal: https://github.com/spark008/screen-enumeration/blob/master/EXPLAINER.md Use the existing Display mojo struct, instead of a new parallel struct. Add [RuntimeEnabled=ScreenEnumeration] Screen attributes, instead of a new parallel object. Rename requestDisplays to getScreens. Update test expectations. Test with chrome://flags#enable-experimental-web-platform-features or --enable-blink-features=ScreenEnumeration Bug: 994889 Test: Automated; getScreens() works with flag enabled. Change-Id: I54f1594c5b6f1ad2a6532f3ee5f8a0184408c7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842339 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#712839}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1842339
branch
from
139f20c
to
40aa22d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update code to better match the latest Screen Enumeration proposal:
https://github.com/spark008/screen-enumeration/blob/master/EXPLAINER.md
Use the existing Display mojo struct, instead of a new parallel struct.
Add [RuntimeEnabled=ScreenEnumeration] Screen attributes, instead of a new parallel object.
Rename requestDisplays to getScreens. Update test expectations.
Test with chrome://flags#enable-experimental-web-platform-features or --enable-blink-features=ScreenEnumeration
Bug: 994889
Test: Automated; getScreens() works with flag enabled.
Change-Id: I54f1594c5b6f1ad2a6532f3ee5f8a0184408c7b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842339
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Staphany Park <staphany@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712839}