Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swipl: 8.1.4 -> 8.1.15 #70720

Merged
merged 2 commits into from Oct 15, 2019
Merged

swipl: 8.1.4 -> 8.1.15 #70720

merged 2 commits into from Oct 15, 2019

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented Oct 8, 2019 •
edited

Motivation for this change

8.1.4 can no longer download SWI-Prolog packages (pack_list,
pack_install, etc), rendering it much less useful.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @meditans

@yrashk
swipl: 8.1.4 -> 8.1.15
cbb4b91 
8.1.4 can no longer download SWI-Prolog packages (pack_list,
pack_install, etc), rendering it much less useful.
@yrashk yrashk changed the title Swipl 8.1.15 swipl: 8.1.4 -> 8.1.15 Oct 8, 2019
@yrashk yrashk mentioned this pull request Oct 8, 2019
Closed
10 tasks
@yrashk
pakcs: 2.1.1 -> 2.1.2
3e9e182 
packs 2.1.1 build has been observed to be broken by the upgrade of
swiProlog to 8.1.15. Upgrading packs to 2.1.2 seems to resolve this
issue.
@yrashk
Copy link
Contributor Author

yrashk commented Oct 8, 2019

@jonringer I updated the PR to fix the hash and substitute extra /bin/rms.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build swipl

@jonringer
Copy link
Contributor

@GrahamcOfBorg build ape apeClex pakcs swiProlog

@yrashk
Copy link
Contributor Author

yrashk commented Oct 10, 2019

@jonringer Should I do anything else about this PR?

@jonringer
Copy link
Contributor

this isn't able to build on darwin

/tmp/nix-build-swi-prolog-8.1.15.drv-0/swipl-devel/packages/ssl/cryptolib.c:60:25: error: invalid application of 'sizeof' to an incomplete type 'EVP_MD_CTX' (aka 'struct evp_md_ctx_st')
{ return OPENSSL_zalloc(sizeof(EVP_MD_CTX));

I wonder if we should mark it linux only, or use a gcc toolchain...

@yrashk
Copy link
Contributor Author

yrashk commented Oct 10, 2019

@jonringer I am not knowledgeable enough about this particular issue. What do you think is best?

@jonringer
Copy link
Contributor

I'm not a darwin guy. cc @marsam @risicle

@marsam marsam merged commit a388e92 into NixOS:master Oct 15, 2019
@marsam
Copy link
Contributor

marsam commented Oct 15, 2019

Thanks, LGTM. I'm going to fix the darwin build in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yrashk @jonringer @marsam