Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swipl: 8.1.4 -> 8.1.13 #68675

Closed
wants to merge 2 commits into from
Closed

swipl: 8.1.4 -> 8.1.13 #68675

wants to merge 2 commits into from

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented Sep 13, 2019 •
edited

8.1.4 can no longer download SWI-Prolog packages (pack_list,
pack_install, etc), rendering it much less useful.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @meditans

@yrashk
swipl: 8.1.4 -> 8.1.13
6db7f18 
8.1.4 can no longer download SWI-Prolog packages (pack_list,
pack_install, etc), rendering it much less useful.
@zimbatm
Copy link
Member

zimbatm commented Sep 13, 2019

nix-review:

3 package failed to build:
ape apeClex pakcs

jonringer
jonringer approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (ape broken on master)
diff LGTM
executables seem to work

[2 built (3 failed), 23 copied (175.6 MiB), 17.3 MiB DL]
error: build of '/nix/store/ks9j08siamrhmgdvdmwvdhkhwssxn9wk-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/68675
3 package failed to build:
ape apeClex pakcs

1 package were build:
swiProlog

EDIT: this does cause a regession in pakcs though

@yrashk
pakcs: 2.1.1 -> 2.1.2
00250fe 
packs 2.1.1 build has been observed to be broken by the upgrade of
swiProlog to 8.1.13. Upgrading packs to 2.1.2 seems to resolve this
issue.
@yrashk
Copy link
Contributor Author

yrashk commented Sep 14, 2019

@jonringer I updated pakcs to 2.1.2 -- this seem to have helped.

@yrashk
Copy link
Contributor Author

yrashk commented Oct 8, 2019

Superseded by #70720

@yrashk yrashk closed this Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yrashk @zimbatm @jonringer