Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.digestif: 0.5 → 0.8.0 #70722

Merged
merged 2 commits into from Oct 15, 2019
Merged

ocamlPackages.digestif: 0.5 → 0.8.0 #70722

merged 2 commits into from Oct 15, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 8, 2019 •
edited by maggesi

Motivation for this change

https://github.com/mirage/digestif/blob/master/CHANGES.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Oct 8, 2019

@GrahamcOfBorg build ocamlPackages.digestif

maggesi
maggesi approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@maggesi maggesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use new infrastructure for ocamlPacakges.
Build on macOS.
Diff looks good.

@vbgl vbgl merged commit 0feb4e8 into NixOS:master Oct 15, 2019
@vbgl vbgl deleted the ocaml-digestif-0.8.0 branch October 15, 2019 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maggesi maggesi maggesi approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (new) 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @maggesi