Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devpi-client: 4.1.0 -> 5.0.0 #70721

Merged
merged 1 commit into from Oct 10, 2019
Merged

devpi-client: 4.1.0 -> 5.0.0 #70721

merged 1 commit into from Oct 10, 2019

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Oct 8, 2019

Motivation for this change

devpi-client was broken for quite some time, this PR:

  • unbreaks the package
  • cleans up dependencies
  • and makes deps overridable
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @nlewo

@makefu makefu mentioned this pull request Oct 8, 2019
Merged
9 tasks
@ofborg ofborg bot requested a review from nlewo October 8, 2019 07:03
jonringer
jonringer approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work

[3 built, 13 copied (22.6 MiB), 5.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70721
1 package were build:
devpi-client

pkgs/development/tools/devpi-client/default.nix Outdated Show resolved Hide resolved
@makefu
devpi-client: 4.1.0 -> 5.0.0
1667fe2 
unbreak the package, clean up dependencies and make them overridable
@makefu
Copy link
Contributor Author

makefu commented Oct 10, 2019

@jonringer thanks for the review, i included your suggestions

@jonringer
Copy link
Contributor

@GrahamcOfBorg build devp-client

@jonringer jonringer merged commit 9ae60cf into NixOS:master Oct 10, 2019
@makefu makefu mentioned this pull request Nov 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@makefu @jonringer