Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flashplayer: 32.0.0.255 -> 32.0.0.270 [Critical security fixes] #70853

Merged
merged 2 commits into from Oct 15, 2019

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Oct 9, 2019

Motivation for this change
  • Critical security fixes
  • Other bug fixes

https://helpx.adobe.com/flash-player/release-note/fp_32_air_32_release_notes.html
https://helpx.adobe.com/security/products/flash-player/apsb19-46.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

  • Built packages

    • nix-env -i -f . -A pkgs.flashplayer
    • nix-build -I nixpkgs=. -o flashplayer_i686 -A pkgsi686Linux.flashplayer
    • nix-build -I nixpkgs=. -o flashplayer_debug -E "(import <nixpkgs> {}).flashplayer.override { debug = true; }"
    • nix-build -I nixpkgs=. -o flashplayer_i686_debug -E "(import <nixpkgs> {}).pkgsi686Linux.flashplayer.override { debug = true; }"
    • nix-build -I nixpkgs=. -o flashplayer_standalone -A pkgs.flashplayer-standalone
    • nix-build -I nixpkgs=. -o flashplayer_standalone_debug -A pkgs.flashplayer-standalone-debugger
    • nix-build -I nixpkgs=. -o chromium -E "(import <nixpkgs> {}).chromium.override { enablePepperFlash = true; }"
  • Played those videos with Firefox (x86_64) and Chromium (x86_64)

Notify maintainers

cc @

Copy link
Member

@KamilaBorowska KamilaBorowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flashplayer-ppapi package is missing maintainers (feel free to add yourself) and a license (unfree), flashplayer-standalone is missing maintainers.

@KamilaBorowska
Copy link
Member

CVE numbers for reference: CVE-2019-8069 and CVE-2019-8070

@taku0
Copy link
Contributor Author

taku0 commented Oct 9, 2019

Added a maintainer and the license.

@c0bw3b c0bw3b added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 11, 2019
@bb010g
Copy link
Member

bb010g commented Oct 14, 2019

Fixes flashplayer-standalone for me.

@taku0
Copy link
Contributor Author

taku0 commented Oct 15, 2019

flashplayer-standalone works to me now.

@c0bw3b c0bw3b merged commit e77a6ec into NixOS:master Oct 15, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 15, 2019

Backported to releases 19.09 and 19.03

@c0bw3b c0bw3b added the 8.has: port to stable A PR already has a backport to the stable release. label Oct 16, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 24, 2019
flashplayer: 32.0.0.255 -> 32.0.0.270 [Critical security fixes]
(cherry picked from commit e77a6ec)
@c0bw3b c0bw3b removed the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants