Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ispc: use cmake for building. #70851

Merged
merged 1 commit into from
Feb 10, 2020
Merged

ispc: use cmake for building. #70851

merged 1 commit into from
Feb 10, 2020
+11 −17

Conversation

athas
Copy link
Contributor

@athas athas commented Oct 9, 2019 •
edited
Loading

The Makefile approach is gone in newer versions of ispc.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @aristidb

Sorry, something went wrong.

@ofborg ofborg bot requested a review from aristidb October 9, 2019 11:34
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 9, 2019
@athas
Copy link
Contributor Author

athas commented Oct 10, 2019

I pushed new changes. It now builds well on my NixOS machine (left my Mac at work so can't test there).

@jonringer
Copy link
Contributor

@GrahamcOfBorg build ispc

@athas
ispc: use cmake for building.

Unverified

The email in this signature doesn’t match the committer email.
GPG key ID: 063CCCAD04182D32
Expired
Learn about vigilant mode
4b4b7fd 
The Makefile approach is gone in newer versions of ispc.
@athas
Copy link
Contributor Author

athas commented Feb 8, 2020

Any news here? The ispc in Nixpkgs is now two releases behind upstream, presumably because the newer ispcs have removed the Makefiles used by Nixpkgs.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Feb 8, 2020
jonringer
jonringer approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[5 built, 80 copied (1632.2 MiB), 288.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70851
3 package built:
embree2 ispc luxcorerender

@jonringer
Copy link
Contributor

@GrahamcOfBorg build embree2 ispc luxcorerender

@jonringer jonringer merged commit 170eefb into NixOS:master Feb 10, 2020
@athas
Copy link
Contributor Author

athas commented Feb 10, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@aristidb aristidb

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@athas @jonringer