Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: fix /sbin/modprobe usage in logind, nspawn@ service files #70683

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 7, 2019

Motivation for this change

Thoughts? Happened to notice in logs, and seems a broken path for
modprobe couldn't possibly be desired :).

If we want to disable this functionality then instead we should delete
these lines instead of leaving them mentioning /sbin/modprobe

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ofborg ofborg bot requested review from edolstra, andir and Mic92 October 8, 2019 00:07
@edolstra edolstra merged commit 72531b1 into NixOS:staging Oct 8, 2019
@dtzWill dtzWill deleted the fix/systemd-refs-to-sbin-modprobe branch October 8, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants