mumble/murmur: Fix .override not working #70685
Merged
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately there's no pkgs.libsForQt5.callPackages, which we need here to get .override attributes on all derivation attributes. It's also non-trivial to add it without duplicating code. So instead just use standard pkgs.callPackages and pass refer to qt libs through pkgs.qt5
10 tasks
ofborg
bot
added
10.rebuild-darwin: 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #68800 (comment)
Unfortunately there's no
pkgs.libsForQt5.callPackages, which we need here toget
.overrideattributes on all derivation attributes. It's alsonon-trivial to add it without duplicating code.
So instead just use standard
pkgs.callPackagesand pass refer to qt libsthrough
pkgs.qt5Ping @ajs124 @greizgh
Things done
.overrideworks again on mumble and murmur