Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entr: 4.2 -> 4.3, pname #70682

Closed
wants to merge 1 commit into from
Closed

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 7, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor

I think you're missing some changes, it just has out -> placeholder "out" right now

@jonringer
Copy link
Contributor

or it's like this because #70579 got merged

@jonringer jonringer mentioned this pull request Oct 8, 2019
10 tasks
@dtzWill
Copy link
Member Author

dtzWill commented Oct 8, 2019

Hahaha, sorry I missed that this was already merged. The change here isn't worth it I don't think :).

@dtzWill dtzWill closed this Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants