Remove world-writability from {profiles,gcroots}/per-user #3136
+82
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbauer
reviewed
Oct 9, 2019
matthewbauer
reviewed
Oct 9, 2019
|
The install matrix failed on almost all cases: https://buildkite.com/organizations/grahamc/pipelines/nix-install-matrix/builds/33/jobs/b20b2d91-a52a-41be-b210-ca8b6a5709eb/artifacts/bdfccc3f-8bd0-4917-b266-96a5a0ce0b23 Seems the problem is quite consistently:
I ran this after the first push. I'll re-run (but on a bigger server so it doesn't take 2h...) |
|
Where are you seeing that? Your link shows a lot of "command not found" errors. |
|
pro tip: open them in two windows next to each other, and zoom out of the page as much as possible to compare. |
|
Can we please have the CVE in at least one of the commit messages, for future reference? |
edolstra
force-pushed
the
no-world-writable
branch
from
fe11f8a to
9fbd222
Compare
'nix-daemon' now creates subdirectories for users when they first connect. Fixes #509 (CVE-2019-17365). Should also fix #3127.
This is already done by the installer, so no need to do it again.
700 is pointless since the store is world-readable anyway. And per-user/root/channels must be world-readable.
edolstra
force-pushed
the
no-world-writable
branch
from
9fbd222 to
20eec80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These directories are now created on demand by the daemon.
Also some simplifications to the profile scripts.
Alternative to #3134, #3135.