Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Actions] dry run the manifest workflow on pull requests #19573

Merged
merged 4 commits into from Oct 8, 2019

Conversation

foolip
Copy link
Member

@foolip foolip commented Oct 8, 2019

To avoid mishaps like #19568 (comment).

@jugglinmike
Copy link
Contributor

get_pr currently logs an error if it can't find a merged pull request. It doesn't influence the process's return code, but it is a bit confusing (since it's completely expected for the dry run). How about relocating the message until after we've exited due to the dry run, just before we exit with a non-zero code?

@foolip
Copy link
Member Author

foolip commented Oct 8, 2019

get_pr might call logger.error or logger.warning with different messages, and returning None doesn't always involve a message, so trying to suppress the messages would get a bit unsightly. How about just not call get_pr at all in dry run mode and leaving it untested like the later bits?

@jugglinmike jugglinmike merged commit ca1a7a2 into master Oct 8, 2019
@foolip foolip deleted the foolip/manifest-dry-run branch October 9, 2019 05:04
@foolip
Copy link
Member Author

foolip commented Oct 9, 2019

@jugglinmike the wpt commit history is far from tidy, but when squashing a commit as in ca1a7a2 feel free to edit the commit message quite liberally and delete parts like the double subject and intermediate steps like "Update manifest_build.py".

@foolip
Copy link
Member Author

foolip commented Oct 9, 2019

If you haven't already noticed and been amused, try git log --grep 'fixup!' for a long list of amusing failures to clean up commit messages :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants