[LayoutNG] Fix font-orientation segmentation #19574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 8, 2019
When there are no script segments (i.e., all the text is in single script) and in vertical flow, we create a single segment and split it at the font-orientation boundaries. This patch fixes to create the single segment from the first text item, not from the first item. If it is created from the first item and the first item is not a text item, we may give incorrect script and/or font-orientation to HarfBuzz. Bug: 1006154 Change-Id: I5ea87920f8cbc76cdc13fe25611f7a7a34284813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847697 Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#703803}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1847697
branch
from
30313fb
to
b5e32bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no script segments (i.e., all the text is in
single script) and in vertical flow, we create a single
segment and split it at the font-orientation boundaries.
This patch fixes to create the single segment from the first
text item, not from the first item. If it is created from the
first item and the first item is not a text item, we may give
incorrect script and/or font-orientation to HarfBuzz.
Bug: 1006154
Change-Id: I5ea87920f8cbc76cdc13fe25611f7a7a34284813
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847697
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703803}