Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r19.09] pythonPackages.pandas: 0.25.0 -> 0.25.1 #70792

Merged
merged 1 commit into from Oct 9, 2019
Merged

[r19.09] pythonPackages.pandas: 0.25.0 -> 0.25.1 #70792

merged 1 commit into from Oct 9, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 8, 2019

(cherry picked from commit 8044cf3)

Motivation for this change

Backport of #70473 - A bugfix release to pandas that fixes trackpy, though someone seems to have got to it before me and disabled some of its tests. This actually makes those work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@risicle risicle requested a review from FRidh as a code owner October 8, 2019 21:30
@ofborg ofborg bot requested review from 7c6f434c and knedlsepp October 8, 2019 21:49
@FRidh FRidh merged commit f7c5e7a into NixOS:release-19.09 Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @7c6f434c @FRidh