Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atom, atom-beta: 1.36.1 -> 1.40.0, 1.37.0-beta0 -> 1.41.0-beta0 #70895

Closed
wants to merge 1 commit into from
Closed

atom, atom-beta: 1.36.1 -> 1.40.0, 1.37.0-beta0 -> 1.41.0-beta0 #70895

wants to merge 1 commit into from

Conversation

Synthetica9
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @offlinehacker @NeQuissimus @ysndr

NeQuissimus
NeQuissimus approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@NeQuissimus NeQuissimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit msg is off, since the stable update goes to 1.40, not 1.41, but otherwise things seem OK

@Synthetica9
Copy link
Member Author

The commit msg is off, since the stable update goes to 1.40, not 1.41, but otherwise things seem OK

Fixed that now.

@Synthetica9 Synthetica9 changed the title atom, atom-beta: 1.36.1 -> 1.41.0, 1.37.0-beta0 -> 1.41.0-beta0 atom, atom-beta: 1.36.1 -> 1.40.0, 1.37.0-beta0 -> 1.41.0-beta0 Oct 10, 2019
@ofborg ofborg bot requested a review from NeQuissimus October 10, 2019 11:54
ysndr
ysndr approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@ysndr ysndr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can't try it out right now though.
Have you tried running atom/atom-beta in a pure nix-shell?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@ysndr ysndr ysndr approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Synthetica9 @NeQuissimus @ysndr