vendor.intel: reset synchronisers #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## vendor.altera #246 +/- ##
=================================================
+ Coverage 82.33% 82.52% +0.18%
=================================================
Files 33 33
Lines 5514 5498 -16
Branches 1180 1180
=================================================
- Hits 4540 4537 -3
+ Misses 839 824 -15
- Partials 135 137 +2
Continue to review full report at Codecov.
|
whitequark
reviewed
Oct 9, 2019
whitequark
reviewed
Oct 9, 2019
whitequark
reviewed
Oct 9, 2019
nmigen/vendor/intel.py
Outdated
| def get_reset_sync(self, reset_sync): | ||
| m = Module() | ||
| reset = Signal() | ||
| reset_clk = ClockSignal(reset_sync._domain) |
There was a problem hiding this comment.
I think you can just use ClockSignal and ResetSignal directly in instance ports.
whitequark
force-pushed
the
vendor.altera
branch
from
0b1afa2
to
ddcff57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't actually find any documentation on this, so I'm working based on the simulation model for this, and hoping for the best.