Fix webxr test and sample references to supportsSession #19605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 9, 2019
Since supportsSession is removed from the spec, convert external webxr wpt's that rely on that method to internal tests while that method is deprecated but but still implemented. Update browser tests and sample pages to use the non-deprecated method as well. Bug: 1009052 Change-Id: I30249e38828726b31668b609a491792ef17c22ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850361 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#704372}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1850361
branch
from
c01db14
to
11f86b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since supportsSession is removed from the spec, convert external webxr
wpt's that rely on that method to internal tests while that method is
deprecated but but still implemented. Update browser tests and sample
pages to use the non-deprecated method as well.
Bug: 1009052
Change-Id: I30249e38828726b31668b609a491792ef17c22ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850361
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704372}