Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualbox: 6.0.10 -> 6.0.12 #70881

Merged
merged 1 commit into from Oct 11, 2019
Merged

virtualbox: 6.0.10 -> 6.0.12 #70881

merged 1 commit into from Oct 11, 2019

Conversation

KamilaBorowska
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @flokli @svanderburg

@KamilaBorowska
Copy link
Member Author

KamilaBorowska commented Oct 9, 2019 •
edited

Something of note: Starting machines did not work until reboot after switch update. It's probably not a big deal however, and it's related to kernel modules maybe?

@flokli
Copy link
Contributor

flokli commented Oct 11, 2019

@GrahamcOfBorg test virtualbox

@flokli
Copy link
Contributor

flokli commented Oct 11, 2019

Tests succeeded, also successfully started a VM on my laptop with that PR.

@flokli flokli merged commit fb5f649 into NixOS:master Oct 11, 2019
@flokli
Copy link
Contributor

flokli commented Oct 11, 2019

Backported to 19.09 in 399e00d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanderburg svanderburg Awaiting requested review from svanderburg

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KamilaBorowska @flokli